Fix varargs calls #188
Merged
Fix varargs calls #188
+72
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Libtask.jl documentation for PR #188 is available at: |
|
This great tip from @simeonschaub helped me simplify the implemenation a lot. I feel much less insecure about the new version, but would still be good to get Will's comments on this. |
willtebbutt
approved these changes
Jun 17, 2025
There was a problem hiding this comment.
This is very nice indeed.
Thanks @simeonschaub for the advice.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another case where I'm changing things that I only have a superficial understanding of. @willtebbutt, could you please check that
check_varargsmakes sense to you, and feel free to propose a better solution.All the tests added here fail on main.
Closes #186